JPDev@programming.dev to Programmer Humor@programming.dev · 5 months ago===programming.devimagemessage-square76fedilinkarrow-up1692arrow-down117
arrow-up1675arrow-down1image===programming.devJPDev@programming.dev to Programmer Humor@programming.dev · 5 months agomessage-square76fedilink
minus-squarekevincox@lemmy.mllinkfedilinkarrow-up2·5 months agoI just tested and Terser will convert v === null || v === undefined to null==v. Personally I would prefer to read the code that explicitly shows that it is checking for both and let my minifier/optimizer worry about generating compact code.
minus-squareSzethFriendOfNimi@lemmy.worldcakelinkfedilinkarrow-up1arrow-down1·5 months agoTry changing to const === variable. That’s most likely what’s it doing to minimize the risk of accidental assignment.
minus-squarekevincox@lemmy.mllinkfedilinkarrow-up3·5 months agoWut? This is an automated optimizer. It is not worried about accidental assignment.
minus-squareSzethFriendOfNimi@lemmy.worldcakelinkfedilinkarrow-up1·5 months agoI agree it shouldn’t. But I’ve seen linters that automatically change it since they seem to be forcing practical conventions sometimes.
minus-squarekevincox@lemmy.mllinkfedilinkarrow-up3·5 months agoLinters and minifers are completely different tools.
minus-squareSzethFriendOfNimi@lemmy.worldcakelinkfedilinkarrow-up3·5 months agoGood point. That’s what I get for shooting from the hip. Thanks!
I just tested and Terser will convert
v === null || v === undefinedtonull==v. Personally I would prefer to read the code that explicitly shows that it is checking for both and let my minifier/optimizer worry about generating compact code.Try changing to const === variable. That’s most likely what’s it doing to minimize the risk of accidental assignment.
Wut? This is an automated optimizer. It is not worried about accidental assignment.
I agree it shouldn’t. But I’ve seen linters that automatically change it since they seem to be forcing practical conventions sometimes.
Linters and minifers are completely different tools.
Good point. That’s what I get for shooting from the hip.
Thanks!