Nice feature!

Even though Evil has this built in, I like the way this is incremental. I’ll give it a look, thanks for making it!

for performance, does it only highlight matches in the displayed part of buffers?

Here is another on MELPA — region-occurrences-highlighter. Not sure what are the differences.